build,win: delegate lint-cpp to make

[refack]

The script to collect and lint C/C++ files has become unruly, and carried a significant maintenance burned. IMHO delegating this task to make is the optimal solution , since we already have MSYS as a prerequisite for developing.

• Patch to Makefile is so that $(shell ...) expressions are evaluated only when needed. Makefile changes moved to build: more portable Makefile #28108

Fixes: #28086

/CC @nodejs/build-files @nodejs/platform-windows

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23838/
CI: https://ci.nodejs.org/job/node-test-pull-request/23857/

[targos]

We don't exactly have MSYS as a prerequisite. The building guide says "Basic Unix tools required for some tests, Git for Windows includes Git Bash and tools which can be included in the global PATH."
On my machine, I installed Git with the additional Unix tools and it doesn't include make

[refack]

I installed Git with the additional Unix tools and it doesn't include make

Oof... Yeah, I have extra MSYS tools 🤦‍♂
This was too good to be true.

[refack]

@targos I vendored in a minimal MSYS make to help the Windows folks. It's just 19 files and 10MB in size. Let's discuss...

[richardlau]

@targos I vendored in a minimal MSYS make to help the Windows folks. It's just 19 files and 10MB in size. Let's discuss...

But that's an additional 10MB that everyone is going to download (including non-Windows users). git really isn't a good place to store binaries.

Additionally we should not be adding GPL licenses/GPL-licensed files into the source tree (even if it applies to tooling and not the code we're actually building).

[refack]

But that's an additional 10MB that everyone is going to download (including non-Windows users). git really isn't a good place to store binaries.

Yeah I've been thinking about this... I'm thinking of packing this as a separate archive, and adding a "win-lint-build" step.

Additionally we should not be adding GPL licenses/GPL-licensed files into the source tree (even if it applies to tooling and not the code we're actually building).

Ack. I was also reading reviews of GPL, in the context of this use case... AFAICT an independent pack should solve that.

[refack]

@richardlau went in a different direction; best effort search in the Path and attempt calling wsl.

binaries no longer included in the PR

[richardlau]

@richardlau went in a different direction; best effort search in the Path and attempt calling wsl.

I've dismissed my objection as it's been addressed. I'm not explicitly approving because I'm -0.5 on a new requirement of GNU make to lint on Windows.

[refack]

I'm -0.5 on a new requirement of GNU make to lint on Windows.

FTR, required just for linting C/C++, but I understand the hesitation.

I do believe that having a minimal make+bash easy to deploy package could allow us to eliminate much of the disparity and duplication between Makefile and vcbuild.bat, but this definatly needs some buy-in from Windows first devs.

[joyeecheung]

Can we move the scripting to Python instead? I understand that on Windows we won't get the dependency update management from Make, but it has always been that way?

[joaocgreis]

I agree with @joyeecheung, it would be better to have this in Python to be available everywhere without any added dependencies. But this is better than what is currently in master, we can work on the Python version later.