Uh oh!
There was an error while loading. Please reload this page.
tls: remove unnecessary set of DEFAULT_MAX_VERSION - #28147
Closed
danbev wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Jun 10, 2019
Collaborator
Sadly, an error occurred when I tried to trigger a build. :( |
nodejs-github-bot
commented
Jun 10, 2019
Collaborator
addaleax
approved these changes
Jun 10, 2019
sam-github
approved these changes
Jun 10, 2019
cjihrig
approved these changes
Jun 10, 2019
jasnell
approved these changes
Jun 10, 2019
trivikr
commented
Jun 10, 2019
Member
Do we need to remove |
lpinca
approved these changes
Jun 10, 2019
richardlau
approved these changes
Jun 11, 2019
richardlau
commented
Jun 11, 2019
Member
No. This PR doesn't remove |
trivikr
approved these changes
Jun 11, 2019
Trott
approved these changes
Jun 11, 2019
ContributorAuthor
Re-build of failing node-test-commit-linux-containered (🔴) |
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE.
danbevforce-pushed
the
tls_default_max_version
branch
from
June 17, 2019 08:45
2aec0f5 to
85777f8Comparenodejs-github-bot
commented
Jun 17, 2019
Collaborator
danbev
commented
Jun 17, 2019
ContributorAuthor
Re-run of failing node-test-commit-osx (✔️) |
danbev
commented
Jun 17, 2019
ContributorAuthor
Landed in c925d1d. |
danbev added a commit
that referenced
this pull request
Jun 17, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Jun 17, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Jun 18, 2019
This commit removes what looks like an unnecessary setting of exports.DEFAULT_MAX_VALUE. PR-URL: #28147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes what looks like an unnecessary setting of
exports.DEFAULT_MAX_VALUE.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes