Uh oh!
There was an error while loading. Please reload this page.
readline: fix tab completion bug - #2816
Closed
mtharrison wants to merge 1 commit into
Closed
Conversation
This fixes a problem where tab completion is empty when the input stream column size is undefined. As a solution we can force maxColumns to 1 in this scenario.
silverwind
commented
Sep 11, 2015
Contributor
LGTM now. |
Fishrock123
commented
Sep 12, 2015
Contributor
silverwind
commented
Sep 18, 2015
Contributor
Landed in e29e470. Thanks @mtharrison! |
mtharrison
commented
Sep 18, 2015
ContributorAuthor
🎉 This makes me so happy! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem where tab completion is empty when the input
stream column size is
undefined. As a solution we can forcemaxColumnsto 1 in this scenario.
Fixes: #2396
Related PR: #2612