Skip to content

doc: pass path in URL constructor - #28161

Closed
dnalborczyk wants to merge 1 commit into
nodejs:masterfrom
dnalborczyk:esm-doc-url
Closed

doc: pass path in URL constructor#28161
dnalborczyk wants to merge 1 commit into
nodejs:masterfrom
dnalborczyk:esm-doc-url

Conversation

@dnalborczyk

@dnalborczykdnalborczyk commented Jun 10, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

simplifies doc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2019
@ZYSzys

ZYSzys commented Jun 14, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3679/

@ZYSzysZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2019
@ZYSzys

ZYSzys commented Jun 14, 2019

Copy link
Copy Markdown
Member

Landed in b5e8181 🎉

@ZYSzysZYSzys closed this Jun 14, 2019
ZYSzys pushed a commit that referenced this pull request Jun 14, 2019
@dnalborczyk@ZYSzys
doc: pass path in URL constructor
b5e8181
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@dnalborczyk@BridgeAR
doc: pass path in URL constructor
07ab591
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@dnalborczyk@targos
doc: pass path in URL constructor
694faf1
PR-URL: #28161
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dnalborczyk@ZYSzys@jasnell@Trott@lpinca@TimothyGu@BridgeAR@nodejs-github-bot