Skip to content

tools: update eslint to latest - #28173

Closed
BridgeAR wants to merge 4 commits into
nodejs:masterfrom
BridgeAR:update-eslint-to-latest
Closed

tools: update eslint to latest#28173
BridgeAR wants to merge 4 commits into
nodejs:masterfrom
BridgeAR:update-eslint-to-latest

Conversation

@BridgeAR

@BridgeARBridgeAR commented Jun 11, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2019

Copy link
Copy Markdown
Collaborator

Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 11, 2019
targos
targos approved these changes Jun 11, 2019
View reviewed changes

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

trivikr
trivikr approved these changes Jun 11, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR

BridgeAR commented Jun 11, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3674/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2019
@Trott

Trott commented Jun 12, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Nit 1: Please specify what version you are upgrading to in the commit message. (Preferably what version we're upgrading from as well.)

Nit 2: If I'm not mistaken, unneeded disable comments will result in errors with our configuration. If I'm right about that, then make lint-js will fail when the first commit lands but the second does not. If that's the case (and again, I believe it is), please squash the two commits into a single commit so that there isn't a commit where linting fails.

@BridgeAR
BridgeARforce-pushed the update-eslint-to-latest branch from 1739468 to 70e595cCompareJune 12, 2019 09:18
@BridgeAR

BridgeAR commented Jun 12, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott thanks, I forgot that it would complain about the comments if they are not required. I updated the PR and incorporated the suggestions.

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3675/

@BridgeAR
tools: update eslint
0f116e5
This updates eslint from v6.0.0-alpha.2 to v6.0.0-rc.0.
This also removes eslint-disable comments about `bigint` typeof
checks. Those would otherwise have caused linting errors now that
`bigint` is accepted as valid entry.
@BridgeAR
BridgeARforce-pushed the update-eslint-to-latest branch from 70e595c to 0f116e5CompareJune 17, 2019 10:17
@BridgeAR

BridgeAR commented Jun 17, 2019

Copy link
Copy Markdown
MemberAuthor

Rebased due to conflicts.

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3686/

@BridgeAR

BridgeAR commented Jun 20, 2019

Copy link
Copy Markdown
MemberAuthor

New CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3694/

@ZYSzys

ZYSzys commented Jun 22, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@BridgeAReslint@6.0.0 was just released. How about updating to v6.0.0 directly ?

And update this line to eslint@latest ?

node/tools/update-eslint.sh

Line 16 in e4136c1

npm install --global-style --no-bin-links --production --no-package-lock eslint@next

Refs: https://github.com/eslint/eslint/releases/tag/v6.0.0

@BridgeAR

BridgeAR commented Jun 22, 2019

Copy link
Copy Markdown
MemberAuthor

Updated to the latest release.

ZYSzys
ZYSzys approved these changes Jun 23, 2019
View reviewed changes

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still RSLGTM.

@cjihrig

cjihrig commented Jun 25, 2019

Copy link
Copy Markdown
Contributor

ESLint 6.0.1 was released. Please skip 6.0.0 before landing this.

@BridgeAR

BridgeAR commented Jun 26, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3721/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Jun 27, 2019
@BridgeAR
tools: update eslint
ed8fc7e
This updates eslint from v6.0.0-alpha.2 to v6.0.1
This also removes eslint-disable comments about `bigint` typeof
checks. Those would otherwise have caused linting errors now that
`bigint` is accepted as valid entry.
PR-URL: nodejs#28173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR

BridgeAR commented Jun 27, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in ed8fc7e

targos pushed a commit that referenced this pull request Jul 2, 2019
@BridgeAR@targos
tools: update eslint
023c75e
This updates eslint from v6.0.0-alpha.2 to v6.0.1
This also removes eslint-disable comments about `bigint` typeof
checks. Those would otherwise have caused linting errors now that
`bigint` is accepted as valid entry.
PR-URL: #28173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@BridgeAR@targos
tools: update eslint
b744bd9
This updates eslint from v6.0.0-alpha.2 to v6.0.1
This also removes eslint-disable comments about `bigint` typeof
checks. Those would otherwise have caused linting errors now that
`bigint` is accepted as valid entry.
PR-URL: #28173
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targostargos mentioned this pull request Jul 2, 2019
Merged
@beevelopbeevelop mentioned this pull request Jul 3, 2019
Closed
This was referenced Jul 3, 2019
Closed
Closed
@BridgeAR
BridgeAR deleted the update-eslint-to-latest branch January 20, 2020 12:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@trivikrtrivikrtrivikr approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BridgeAR@nodejs-github-bot@Trott@ZYSzys@cjihrig@targos@trivikr