report: add cpu info to report output by boneskull · Pull Request #28188 · nodejs/node

boneskull · 2019-06-12T15:00:16Z

The report shows CPU consumption %, but without
the number of CPU cores, a consumer cannot tell
if the percent (given across all cores) is
actually problematic. E.g., 100% on one CPU
is a problem, but 100% on four CPUs is not
necessarily (EDIT: the max theoretical usage is 400% in this case)

This change adds CPU information (similar to
os.cpus()) to the report output. Extra
info besides the count is also provided as
to avoid future breaking changes in the
eventuality that someone needs it;
changing the datatype of header.cpus
would be breaking.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-06-12T15:00:20Z

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23823/
CI: https://ci.nodejs.org/job/node-test-pull-request/23825/
CI: https://ci.nodejs.org/job/node-test-pull-request/23880/
CI: https://ci.nodejs.org/job/node-test-pull-request/23884/
CI: https://ci.nodejs.org/job/node-test-pull-request/23898/

boneskull · 2019-06-12T15:00:41Z

Ref: nodejs/diagnostics#307

The report shows CPU consumption %, but without the number of CPU cores, a consumer cannot tell if the percent (given across all cores) is actually problematic. E.g., 100% on one CPU is a problem, but 100% on four CPUs is not necessarily. This change adds CPU information (similar to `os.cpus()`) to the report output. Extra info besides the count is also provided as to avoid future breaking changes in the eventuality that someone needs it; changing the datatype of `header.cpus` would be breaking. PR-URL: nodejs#28188 Refs: nodejs/diagnostics#307

boneskull · 2019-06-14T18:54:58Z

Do I need to wait on CI fix to land this?

Trott · 2019-06-16T02:40:09Z

Do I need to wait on CI fix to land this?

Yes. The tests need to run and pass on all the platforms.

nodejs-github-bot · 2019-06-16T02:40:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23909/

The report shows CPU consumption %, but without the number of CPU cores, a consumer cannot tell if the percent (given across all cores) is actually problematic. E.g., 100% on one CPU is a problem, but 100% on four CPUs is not necessarily. This change adds CPU information (similar to `os.cpus()`) to the report output. Extra info besides the count is also provided as to avoid future breaking changes in the eventuality that someone needs it; changing the datatype of `header.cpus` would be breaking. PR-URL: nodejs#28188 Refs: nodejs/diagnostics#307 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Trott · 2019-06-16T03:53:43Z

Landed in 7561a38

The report shows CPU consumption %, but without the number of CPU cores, a consumer cannot tell if the percent (given across all cores) is actually problematic. E.g., 100% on one CPU is a problem, but 100% on four CPUs is not necessarily. This change adds CPU information (similar to `os.cpus()`) to the report output. Extra info besides the count is also provided as to avoid future breaking changes in the eventuality that someone needs it; changing the datatype of `header.cpus` would be breaking. PR-URL: #28188 Refs: nodejs/diagnostics#307 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2019-06-20T16:54:05Z

This should probably be semver-minor?

cjihrig · 2019-06-20T17:05:59Z

The report feature is still experimental, and does not follow semver.

BridgeAR · 2019-06-20T17:10:55Z

@cjihrig thanks!

Notable changes: This release contains `semver-major` commits. These are in fact not `semver-major` due to follow-up commits that remove all breaking changes. * build: * The startup time is reduced by enabling V8 snapshots by default #28181 * deps: * Updated `V8` to 7.5.288.22 #27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c #28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure #27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant #27851 * report: * The cpu info got added to the report output #28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode #24260 * tools,gyp: * Introduce MSVS 2019 #27375 * util: * inspect: * Array grouping became more compact and uses more columns than before #28059 #28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines #28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated #28021 PR-URL: #28268

Notable changes: * build: * The startup time is reduced by enabling V8 snapshots by default #28181 * deps: * Updated `V8` to 7.5.288.22 #27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c #28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure #27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant #27851 * report: * The cpu info got added to the report output #28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode #24260 * tools,gyp: * Introduce MSVS 2019 #27375 * util: * inspect: * Array grouping became more compact and uses more columns than before #28059 #28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines #28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated #28021 PR-URL: #28268

Notable changes: * build: * The startup time is reduced by enabling V8 snapshots by default nodejs#28181 * deps: * Updated `V8` to 7.5.288.22 nodejs#27375 * The numeric separator (v8.dev/features/numeric-separators) feature is now enabled by default * Updated `OpenSSL` to 1.1.1c nodejs#28211 * inspector: * The `--inspect-publish-uid` flag was added to specify ways of the inspector web socket url exposure nodejs#27741 * n-api: * Accessors on napi_define_* are now ECMAScript-compliant nodejs#27851 * report: * The cpu info got added to the report output nodejs#28188 * src: * Restore the original state of the stdio file descriptors on exit to prevent leaving stdio in raw or non-blocking mode nodejs#24260 * tools,gyp: * Introduce MSVS 2019 nodejs#27375 * util: * inspect: * Array grouping became more compact and uses more columns than before nodejs#28059 nodejs#28070 * Long strings will not be split at 80 characters anymore. Instead they will be split on new lines nodejs#28055 * worker: * `worker.terminate()` now returns a promise and using the callback is deprecated nodejs#28021 PR-URL: nodejs#28268

boneskull added the report Issues and PRs related to process.report. label Jun 12, 2019

boneskull requested review from cjihrig, gireeshpunathil, richardlau and sam-github June 12, 2019 15:00

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 12, 2019

boneskull force-pushed the process-report-cpus branch from e703fd1 to 3f87627Compare June 12, 2019 15:02

sam-github approved these changes Jun 12, 2019
View reviewed changes

Comment threaddoc/api/report.md Outdated

boneskull force-pushed the process-report-cpus branch from 3f87627 to 6f3ddc2Compare June 12, 2019 15:45

gireeshpunathil reviewed Jun 12, 2019
View reviewed changes

Comment threaddoc/api/report.md Outdated

gireeshpunathil approved these changes Jun 12, 2019
View reviewed changes

richardlau approved these changes Jun 12, 2019
View reviewed changes

boneskull removed the request for review from cjihrig June 12, 2019 16:24

BridgeAR approved these changes Jun 12, 2019
View reviewed changes

boneskull force-pushed the process-report-cpus branch from 6f3ddc2 to 6ad680eCompare June 12, 2019 17:05

trivikr approved these changes Jun 12, 2019
View reviewed changes

addaleax approved these changes Jun 12, 2019
View reviewed changes

Comment threaddoc/api/report.md Outdated

cjihrig approved these changes Jun 12, 2019
View reviewed changes

Trott approved these changes Jun 12, 2019
View reviewed changes

jasnell approved these changes Jun 14, 2019
View reviewed changes

boneskull added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 14, 2019

boneskull self-assigned this Jun 14, 2019

boneskull force-pushed the process-report-cpus branch from 6ad680e to b5aa334Compare June 14, 2019 16:09

boneskull force-pushed the process-report-cpus branch from b5aa334 to 3c225eeCompare June 14, 2019 16:10

boneskull force-pushed the process-report-cpus branch from 3c225ee to 7c2fa6bCompare June 14, 2019 16:11

Trott closed this Jun 16, 2019

joyeecheung mentioned this pull request Jun 16, 2019
CI failures: 20190612-20190615 nodejs/reliability#23
Closed

BridgeAR mentioned this pull request Jun 17, 2019
v12.5.0 proposal #28268
Merged

BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 20, 2019

BridgeAR removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 20, 2019

mmarchini mentioned this pull request Jul 8, 2019
proposal: add num cpu cores to process.report output nodejs/diagnostics#307
Closed

boneskull deleted the process-report-cpus branch November 14, 2019 21:11

kissofire mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities kissofire/node#73
Open

wedataintelligence mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#38
Open

ron-a20 mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities ron-a20/node#71
Open

Dmarch28 mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities Dmarch28/node#62
Open

aliceUnhinged613 mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#64
Open

137717unity mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities 137717unity/node#62
Open

baby636 mentioned this pull request Jul 22, 2022
[Snyk] Fix for 1 vulnerabilities baby636/node#61
Open

molllyn1 mentioned this pull request Jul 23, 2022
[Snyk] Fix for 1 vulnerabilities molllyn1/node#53
Open

Navigation Menu

Uh oh!

Uh oh!

report: add cpu info to report output - #28188

report: add cpu info to report output#28188
boneskull wants to merge 1 commit into
nodejs:masterfrom
boneskull:process-report-cpus

boneskull commented Jun 12, 2019•
edited
Loading

Uh oh!

nodejs-github-bot commented Jun 12, 2019•
edited
Loading

Uh oh!

boneskull commented Jun 12, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boneskull commented Jun 14, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

nodejs-github-bot commented Jun 16, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

BridgeAR commented Jun 20, 2019

Uh oh!

cjihrig commented Jun 20, 2019

Uh oh!

BridgeAR commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Uh oh!

Conversation

boneskull commented Jun 12, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Jun 12, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boneskull commented Jun 12, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

boneskull commented Jun 14, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

nodejs-github-bot commented Jun 16, 2019

Uh oh!

Trott commented Jun 16, 2019

Uh oh!

BridgeAR commented Jun 20, 2019

Uh oh!

cjihrig commented Jun 20, 2019

Uh oh!

BridgeAR commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

boneskull commented Jun 12, 2019•
edited
Loading

nodejs-github-bot commented Jun 12, 2019•
edited
Loading