Skip to content

src: fix compiler warning in node_worker.cc - #28198

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:worker_inspector_started_warn
Closed

src: fix compiler warning in node_worker.cc#28198
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:worker_inspector_started_warn

Conversation

@danbev

@danbevdanbev commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Currently, when configuring --without-ssl the following compiler warning
is generated:

../src/node_worker.cc:192:10:warning: unused variable 'inspector_started' [-Wunused-variable] bool inspector_started = false; ^1 warning generated.

This commit adds a macro guard to the variable to avoid the warning.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: fix compiler warning in node_worker.cc
efe351f
Currently, when configuring --without-ssl the following compiler warning
is generated:
../src/node_worker.cc:192:10:
warning: unused variable 'inspector_started' [-Wunused-variable]
bool inspector_started = false;
^
1 warning generated.
This commit adds a macro guard to the variable to avoid the warning.
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Jun 13, 2019
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 13, 2019
@Trott

Trott commented Jun 13, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/23855/ ✔️

@ZYSzys

ZYSzys commented Jun 16, 2019

Copy link
Copy Markdown
Member

Landed in 2b7dfbc.

@ZYSzysZYSzys closed this Jun 16, 2019
ZYSzys pushed a commit that referenced this pull request Jun 16, 2019
@danbev@ZYSzys
src: fix compiler warning in node_worker.cc
2b7dfbc
Currently, when configuring --without-ssl the following compiler warning
is generated:
../src/node_worker.cc:192:10:
warning: unused variable 'inspector_started' [-Wunused-variable]
bool inspector_started = false;
^
1 warning generated.
This commit adds a macro guard to the variable to avoid the warning.
PR-URL: #28198
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Jun 17, 2019
@danbev@BridgeAR
src: fix compiler warning in node_worker.cc
7a4a94a
Currently, when configuring --without-ssl the following compiler warning
is generated:
../src/node_worker.cc:192:10:
warning: unused variable 'inspector_started' [-Wunused-variable]
bool inspector_started = false;
^
1 warning generated.
This commit adds a macro guard to the variable to avoid the warning.
PR-URL: #28198
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jun 17, 2019
Merged
targos pushed a commit that referenced this pull request Jun 18, 2019
@danbev@targos
src: fix compiler warning in node_worker.cc
029b50d
Currently, when configuring --without-ssl the following compiler warning
is generated:
../src/node_worker.cc:192:10:
warning: unused variable 'inspector_started' [-Wunused-variable]
bool inspector_started = false;
^
1 warning generated.
This commit adds a macro guard to the variable to avoid the warning.
PR-URL: #28198
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
danbev deleted the worker_inspector_started_warn branch August 20, 2019 07:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@ZYSzysZYSzysZYSzys approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@danbev@nodejs-github-bot@Trott@ZYSzys@jasnell@addaleax@lpinca@gengjiawen@richardlau