Skip to content

doc: clarify when http emits aborted event - #28262

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:fix-aborted-docs
Closed

doc: clarify when http emits aborted event#28262
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:fix-aborted-docs

Conversation

@ronag

@ronagronag commented Jun 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Clarify premature close and response object behaviour.

Ref: #28172

Checklist
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jun 17, 2019
Trott
Trott reviewed Jun 17, 2019
View reviewed changes
Comment threaddoc/api/http.md Outdated
Trott
Trott approved these changes Jun 17, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subsystem for the commit message should be doc:. Maybe something like doc: clarify when http emits aborted event? This is something that can be handled by whoever lands the PR but if you want to save someone a few keystrokes, by all means, amend the commit message and force push.

@ronag
ronagforce-pushed the fix-aborted-docs branch from 0950acc to 8fbda01CompareJune 17, 2019 23:15
Trott
Trott reviewed Jun 18, 2019
View reviewed changes
Comment threaddoc/api/http.md Outdated
@ronag@Trott
Update doc/api/http.md
cbbc403
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Jun 18, 2019

Copy link
Copy Markdown
Member

@nodejs/http (just in case this is a bug that needs to be fixed rather than a peculiarity that needs to be documented or something like that)

@trivikrtrivikr changed the title http: clarify aborteddoc: clarify when http emits aborted eventJun 18, 2019
@ronag

ronag commented Jun 18, 2019

Copy link
Copy Markdown
MemberAuthor

This is relevant #28172 and argues a change in behaviour. However, if or until then I suggest we should clarify the existing behaviour.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 18, 2019
@Trott

Trott commented Jun 18, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3689/

@addaleax

addaleax commented Jun 19, 2019

Copy link
Copy Markdown
Member

Landed in 1a4f27a

addaleax pushed a commit that referenced this pull request Jun 19, 2019
@ronag@addaleax
doc: clarify when http emits aborted event
1a4f27a
PR-URL: #28262
Refs: #28172
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 2, 2019
@ronag@targos
doc: clarify when http emits aborted event
359e20f
PR-URL: #28262
Refs: #28172
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targostargos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@fhinkelfhinkelfhinkel approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@Trott@addaleax@fhinkel@BridgeAR@trivikr@nodejs-github-bot