Skip to content

tools: update babel-eslint to 10.0.2 - #28266

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:babel-eslint
Closed

tools: update babel-eslint to 10.0.2#28266
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:babel-eslint

Conversation

@ZYSzys

@ZYSzysZYSzys commented Jun 17, 2019

Copy link
Copy Markdown
Member

Update babel-eslint to 10.0.2 by running tools/update-babel-eslint.sh.

Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 17, 2019
@ZYSzys

Copy link
Copy Markdown
MemberAuthor

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

This seems to add a few files that were missing before 👍 (even though it seems like we did not require them).

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 17, 2019

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-rubber-stamp LGTM. The change set is manageable so I was able to actually review it. :-D

@ZYSzys

Copy link
Copy Markdown
MemberAuthor

Landed in d698983.

@ZYSzysZYSzys closed this Jun 20, 2019
@ZYSzys
ZYSzys deleted the babel-eslint branch June 20, 2019 05:56
targos pushed a commit that referenced this pull request Jul 2, 2019
PR-URL: #28266
Refs: https://github.com/babel/babel-eslint/releases/tag/v10.0.2
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Jul 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ZYSzys@fhinkel@Trott@cjihrig@BridgeAR@trivikr@nodejs-github-bot