Uh oh!
There was an error while loading. Please reload this page.
doc: revise strict mode text in assert - #28285
Merged
Merged
Conversation
Trottforce-pushed
the
revise-strict-mode-yo
branch
from
June 19, 2019 05:16
f96e5f4 to
cfbd5f5CompareTrott
commented
Jun 19, 2019
MemberAuthor
BridgeAR
approved these changes
Jun 19, 2019
trivikr
approved these changes
Jun 19, 2019
Revise the text describing `strict` mode. PR-URL: nodejs#28285 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trottforce-pushed
the
revise-strict-mode-yo
branch
from
June 21, 2019 09:30
cfbd5f5 to
3af27f8CompareTrott
commented
Jun 21, 2019
MemberAuthor
Landed in 3af27f8 |
targos pushed a commit
that referenced
this pull request
Jul 2, 2019
Revise the text describing `strict` mode. PR-URL: #28285 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise the text describing
strictmode.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes