Skip to content

[v10.x] n-api: implement date object - #28298

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-25917-to-v10.x
Closed

[v10.x] n-api: implement date object#28298
gabrielschulhof wants to merge 1 commit into
nodejs:v10.x-stagingfrom
gabrielschulhof:backport-25917-to-v10.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Implements napi_create_date() as well as napi_is_date() to
allow working with JavaScript Date objects.

PR-URL: #25917

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v10.x labels Jun 19, 2019
@gabrielschulhofgabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jun 19, 2019
richardlau
richardlau reviewed Jun 20, 2019
View reviewed changes
Comment threaddoc/api/n-api.md Outdated

@richardlaurichardlauJun 20, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napiVersion shouldn't be set for experimental API's? #28330

@gabrielschulhofgabrielschulhofJun 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardlau OK, that'll have to be backported as well, then.

@gabrielschulhof
gabrielschulhofforce-pushed the backport-25917-to-v10.x branch 2 times, most recently from f029352 to 440570aCompareJune 25, 2019 19:28
@gabrielschulhofgabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Jul 16, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24500/

@mhdawson

mhdawson commented Jul 17, 2019

Copy link
Copy Markdown
Member

@BethGriggs can you take a look to see if this should be in 10.16.1?

@mhdawson

mhdawson commented Jul 17, 2019

Copy link
Copy Markdown
Member

@BethGriggs also can you remind me if we should have the backported-to-10.x label on this once the PR is ready or is that added once it is landed in the older stream?

@BethGriggs

BethGriggs commented Jul 17, 2019

Copy link
Copy Markdown
Member

@mhdawson, just trying to get a green CI/track down the failures before landing this one.

We typically add the land-on-v10.x label once the backport PR has landed on the staging branch, whereas the backported-to-v10.x label would be added to the original PR that landed on master.

@nodejs-github-bot

nodejs-github-bot commented Jul 17, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24512/

@gabrielschulhofgabrielschulhof mentioned this pull request Jul 17, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Jul 23, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24630/

@mhdawson

mhdawson commented Jul 23, 2019

Copy link
Copy Markdown
Member

@BethGriggs thanks for the clarification.

@nodejs-github-bot

nodejs-github-bot commented Jul 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24702/

@jarrodconnollyGabriel Schulhof
n-api: implement date object
ce01f2f
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.
PR-URL: nodejs#25917
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gabrielschulhof

gabrielschulhof commented Sep 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Rebased.

BethGriggs pushed a commit that referenced this pull request Sep 3, 2019
@jarrodconnolly@BethGriggs
n-api: implement date object
4f41e4f
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.
Backport-PR-URL: #28298
PR-URL: #25917
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs

BethGriggs commented Sep 3, 2019

Copy link
Copy Markdown
Member

Landed on v10.x-staging

@gabrielschulhof
gabrielschulhof deleted the backport-25917-to-v10.x branch March 13, 2020 06:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.node-apiIssues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof@nodejs-github-bot@mhdawson@BethGriggs@richardlau@jarrodconnolly