Skip to content

[v8.x] n-api: implement date object - #28301

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-25917-to-v8.x
Closed

[v8.x] n-api: implement date object#28301
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-25917-to-v8.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Implements napi_create_date() as well as napi_is_date() to
allow working with JavaScript Date objects.

PR-URL: #25917

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jun 19, 2019
@gabrielschulhofgabrielschulhof changed the title n-api: implement date object[v8.x] n-api: implement date objectJun 19, 2019
@gabrielschulhofgabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jun 19, 2019
richardlau
richardlau reviewed Jun 20, 2019
View reviewed changes
Comment threaddoc/api/n-api.md Outdated

@richardlaurichardlauJun 20, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

napiVersion shouldn't be set for experimental API's? #28330

@gabrielschulhofgabrielschulhofJul 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to land this as is and then backport #28330.

@mhdawson

mhdawson commented Jul 3, 2019

Copy link
Copy Markdown
Member

@gabrielschulhof I assume that is to keep future backports as clean as possible?

@gabrielschulhofgabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@gabrielschulhof

gabrielschulhof commented Jul 12, 2019

Copy link
Copy Markdown
ContributorAuthor

@mhdawson yes.

@gabrielschulhofgabrielschulhof mentioned this pull request Jul 17, 2019
Closed
@jarrodconnollyGabriel Schulhof
n-api: implement date object
fb4786e
Implements `napi_create_date()` as well as `napi_is_date()` to
allow working with JavaScript Date objects.
PR-URL: nodejs#25917
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gabrielschulhof

gabrielschulhof commented Sep 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25575/

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25580/

@BethGriggsBethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 19, 2019
@gabrielschulhof

gabrielschulhof commented Oct 13, 2019

Copy link
Copy Markdown
ContributorAuthor

v8.x will receive no further minor releases.

@gabrielschulhof
gabrielschulhof deleted the backport-25917-to-v8.x branch October 13, 2019 07:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@mhdawsonmhdawsonAwaiting requested review from mhdawson

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.node-apiIssues and PRs related to the Node-API.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof@mhdawson@nodejs-github-bot@richardlau@BethGriggs@jarrodconnolly