Skip to content

test: remove test-ttywrap.writestream - #28316

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:rm-test-that-never-runs
Jun 22, 2019
Merged

test: remove test-ttywrap.writestream#28316
Trott merged 1 commit into
nodejs:masterfrom
Trott:rm-test-that-never-runs

Conversation

@Trott

@TrottTrott commented Jun 20, 2019

Copy link
Copy Markdown
Member

The test is never run in CI and may have never worked.

Refs: #28304

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 20, 2019
@TrottTrott mentioned this pull request Jun 20, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23995/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2019
@addaleax

addaleax commented Jun 20, 2019

Copy link
Copy Markdown
Member

This is removing a different test than the one that is referenced in the issue … is that intentional?

@Trott

Trott commented Jun 20, 2019

Copy link
Copy Markdown
MemberAuthor

This is removing a different test than the one that is referenced in the issue … is that intentional?

Argh! No, that was an error. Fixing....

@Trott
Trottforce-pushed the rm-test-that-never-runs branch from 113bb30 to 3b97f5dCompareJune 20, 2019 21:02
@TrottTrott changed the title test: remove test-graph.signaltest: remove test-ttywrap.writestreamJun 20, 2019
@Trott

Trott commented Jun 20, 2019

Copy link
Copy Markdown
MemberAuthor

Fixed. Re-running CI....

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24023/

@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24049/

@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24057/

@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24058/

@Trott
test: remove test-ttywrap.writestream.js
6e66313
The test is never run in CI and may have never worked.
Refs: nodejs#28304
PR-URL: nodejs#28316
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trottforce-pushed the rm-test-that-never-runs branch from 3b97f5d to 6e66313CompareJune 22, 2019 13:02
@Trott

Trott commented Jun 22, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 6e66313

@Trott
Trott merged commit 6e66313 into nodejs:masterJun 22, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott@targos
test: remove test-ttywrap.writestream.js
b448db3
The test is never run in CI and may have never worked.
Refs: #28304
PR-URL: #28316
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott
Trott deleted the rm-test-that-never-runs branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@aks-aks-aks- approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@addaleax@jasnell@gireeshpunathil@aks-@trivikr