Uh oh!
There was an error while loading. Please reload this page.
doc: fix typo in process.disconnect() docs - #28328
Merged
Merged
Conversation
richardlau
approved these changes
Jun 20, 2019
trivikr
approved these changes
Jun 20, 2019
Trott
approved these changes
Jun 20, 2019
lpinca
approved these changes
Jun 20, 2019
cjihrig
commented
Jun 21, 2019
ContributorAuthor
BridgeAR
approved these changes
Jun 22, 2019
"that" should be "the" in this sentence. This commit also restructures the sentence to avoid the word "process's" PR-URL: nodejs#28328 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Jul 2, 2019
"that" should be "the" in this sentence. This commit also restructures the sentence to avoid the word "process's" PR-URL: #28328 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"that" should be "the" in this sentence. This commit also
restructures the sentence to avoid the word "process's"
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes