Uh oh!
There was an error while loading. Please reload this page.
test: fixing broken test - #28345
Closed
MelinaMejia95 wants to merge 1 commit into
Closed
Conversation
test didn't throw the error, it was just returning it. So I removed the try/catch and assigned the error to a variable
addaleax
approved these changes
Jun 21, 2019
cjihrig
approved these changes
Jun 21, 2019
Trott
approved these changes
Jun 21, 2019
nodejs-github-bot
commented
Jun 22, 2019
Collaborator
gireeshpunathil
approved these changes
Jun 22, 2019
targos
approved these changes
Jun 22, 2019
nodejs-github-bot
commented
Jun 22, 2019
Collaborator
BridgeAR
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
nodejs-github-bot
commented
Jun 25, 2019
Collaborator
ZYSzys
commented
Jun 26, 2019
Member
Landed in fad3b64 Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
targos pushed a commit
that referenced
this pull request
Jul 2, 2019
test didn't throw the error, it was just returning it. So I removed the try/catch and assigned the error to a variable PR-URL: #28345 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test didn't throw the error, it was just returning it. So I removed
the try/catch and assigned the error to a variable
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes