Skip to content

doc: add example function isDead to cluster - #28362

Closed
jessecogollo wants to merge 5 commits into
nodejs:masterfrom
jessecogollo:doc-idDead-cluster
Closed

doc: add example function isDead to cluster#28362
jessecogollo wants to merge 5 commits into
nodejs:masterfrom
jessecogollo:doc-idDead-cluster

Conversation

@jessecogollo

@jessecogollojessecogollo commented Jun 21, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

[x] added example documentation

@jessecogollo
doc: add example function isDead to cluster
52d6aac
[x] documentation is changed or added
@nodejs-github-botnodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jun 21, 2019
Trott
Trott reviewed Jun 21, 2019
View reviewed changes
Comment threaddoc/api/cluster.md Outdated
Trott
Trott reviewed Jun 21, 2019
View reviewed changes
Comment threaddoc/api/cluster.md Outdated
Trott
Trott reviewed Jun 21, 2019
View reviewed changes
Comment threaddoc/api/cluster.md Outdated
@Trott

Trott commented Jun 21, 2019

Copy link
Copy Markdown
Member

@nodejs/documentation

Trott
Trott previously requested changes Jun 21, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @jessecogollo and thanks for the pull request! It may be possible to simplify/shorten this one a bit? It's probably fine the way it is though? I'm not sure so I pinged the documentation team. Thanks again!

@jessecogollo

jessecogollo commented Jun 21, 2019

Copy link
Copy Markdown
ContributorAuthor

Thank you @Trott.
I made the suggestions, let me know fi any change is necessary.

@Trott
Trott dismissed their stale reviewJune 22, 2019 02:35

changes implemented

trivikr
trivikr reviewed Jun 24, 2019
View reviewed changes
Comment threaddoc/api/cluster.md Outdated
process.kill(process.pid);
}).listen(8000);

// Make http://localhost:8000 to ckeck isDead method.

@trivikrtrivikrJun 24, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

Suggested change
// Make http://localhost:8000 to ckeck isDead method.
// Make http://localhost:8000 to check isDead method.

@TrottTrottJun 24, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Make" means "Make a connection to" here?

Suggested change
// Make http://localhost:8000 to ckeck isDead method.
// Connect to http://localhost:8000 to check isDead().

@jessecogollojessecogolloJun 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Trott and @trivikr typo is fixed. Let me know other comment 😉

Trott
Trott approved these changes Jun 24, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with typo fix. Seems that it could also be simplified/shortened a bit, but that's probably not a big priority. Thanks for the code!

@Trott

Trott commented Jun 25, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3713/

Trott pushed a commit to Trott/io.js that referenced this pull request Jun 25, 2019
@jessecogollo@Trott
doc: add example code for worker.isDead() to cluster.md
e2d445b
PR-URL: nodejs#28362
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Trott commented Jun 25, 2019

Copy link
Copy Markdown
Member

Landed in e2d445b.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@TrottTrott closed this Jun 25, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@jessecogollo@targos
doc: add example code for worker.isDead() to cluster.md
b6d0cbc
PR-URL: #28362
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targostargos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@khriztianmorenokhriztianmorenokhriztianmoreno approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clusterIssues and PRs related to the cluster subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jessecogollo@Trott@jasnell@khriztianmoreno@trivikr@nodejs-github-bot