Uh oh!
There was an error while loading. Please reload this page.
vm: increase code coverage of source_text_module.js - #28363
Closed
kball wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Jun 22, 2019
BridgeAR
approved these changes
Jun 22, 2019
Trott
approved these changes
Jun 23, 2019
nodejs-github-bot
commented
Jun 23, 2019
Collaborator
jasnell
approved these changes
Jun 23, 2019
addaleax
commented
Jun 25, 2019
Member
Landed in 6c2f78e Thanks for the contribution, and welcome to the project! 🎉 |
addaleax pushed a commit
that referenced
this pull request
Jun 25, 2019
PR-URL: #28363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 more line of code coverage: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/internal/vm/source_text_module.js.html#L161
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes