Uh oh!
There was an error while loading. Please reload this page.
refactor test-fs-write-sync - #28371
Closed
gabynr wants to merge 1 commit into
Closed
Conversation
gabynrforce-pushed
the
refactor-test-fs-write-sync
branch
from
June 22, 2019 12:45
681ba76 to
51bc7eeCompareRefactor the code for the test-fs-write-sync to avoid code repetition and to make it simpler.
gabynrforce-pushed
the
refactor-test-fs-write-sync
branch
from
June 23, 2019 23:32
51bc7ee to
ea94748Comparegabynr
commented
Jun 24, 2019
ContributorAuthor
CI passing now. Reworded commit message to include subsystem and pass linting in CI. |
Trott
approved these changes
Jun 24, 2019
nodejs-github-bot
commented
Jun 24, 2019
Collaborator
nodejs-github-bot
commented
Jun 25, 2019
Collaborator
addaleax
approved these changes
Jun 25, 2019
addaleax
left a comment
Member
There was a problem hiding this comment.
Nice PR, I’m a fan of the simplification :)
ZYSzys
approved these changes
Jun 26, 2019
khriztianmoreno
approved these changes
Jul 4, 2019
khriztianmoreno
left a comment
Contributor
There was a problem hiding this comment.
LGTM more simple, I like it.
BridgeAR
approved these changes
Jul 4, 2019
Trott
commented
Jul 7, 2019
Member
Landed in 327c673. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 7, 2019
Refactor the code for the test-fs-write-sync to avoid code repetition and to make it simpler. PR-URL: nodejs#28371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Jul 20, 2019
Refactor the code for the test-fs-write-sync to avoid code repetition and to make it simpler. PR-URL: #28371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the code for the test-fs-write-sync to avoid code repetition
and to make it simpler.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes