Skip to content

worker: assign missing deprecation code - #28395

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:assign-missing-deprecation-code
Closed

worker: assign missing deprecation code#28395
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:assign-missing-deprecation-code

Conversation

@jasnell

@jasnelljasnell commented Jun 23, 2019

Copy link
Copy Markdown
Member

Deprecation code was not assigned.

@nodejs/tooling ... might be worthwhile adding a check for DEP00XX and DEP0XXX in the change using git-node-land

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the worker Issues and PRs related to Worker support. label Jun 23, 2019
@jasnelljasnell added deprecations Issues and PRs related to deprecations. and removed worker Issues and PRs related to Worker support. labels Jun 23, 2019
@nodejs-github-bot

nodejs-github-bot commented Jun 24, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24072/

@addaleax

addaleax commented Jul 3, 2019

Copy link
Copy Markdown
Member

Landed in f5f8a18

@addaleaxaddaleax closed this Jul 3, 2019
@addaleaxaddaleax added the worker Issues and PRs related to Worker support. label Jul 3, 2019
addaleax pushed a commit that referenced this pull request Jul 3, 2019
@jasnell@addaleax
worker: assign missing deprecation code
f5f8a18
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2019
@jasnell@targos
worker: assign missing deprecation code
cbf5401
PR-URL: #28395
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
@richardlaurichardlau mentioned this pull request Jul 14, 2020
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deprecationsIssues and PRs related to deprecations.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jasnell@nodejs-github-bot@addaleax@Trott@lpinca@TimothyGu@cjihrig@richardlau@ZYSzys