Skip to content

[v8.x] n-api: make func argument of napi_create_threadsafe_function optional - #28400

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-27791-to-v8.x
Closed

[v8.x] n-api: make func argument of napi_create_threadsafe_function optional#28400
gabrielschulhof wants to merge 1 commit into
nodejs:v8.x-stagingfrom
gabrielschulhof:backport-27791-to-v8.x

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

PR-URL: #27791
Refs: #27592
Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v8.x labels Jun 24, 2019
@gabrielschulhofgabrielschulhof changed the title n-api: make func argument of napi_create_threadsafe_function optional[v8.x] n-api: make func argument of napi_create_threadsafe_function optionalJun 24, 2019
legendecas
legendecas approved these changes Jun 24, 2019
View reviewed changes

@legendecaslegendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson reviewed Jun 24, 2019
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
mhdawson
mhdawson reviewed Jun 26, 2019
View reviewed changes
Comment threaddoc/api/n-api.md Outdated
@gabrielschulhof
gabrielschulhofforce-pushed the backport-27791-to-v8.x branch from 5b1f497 to 64849c3CompareJuly 1, 2019 18:05
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@nodejs-github-bot

nodejs-github-bot commented Jul 4, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24268/

@nodejs-github-bot

nodejs-github-bot commented Jul 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24312/

@gabrielschulhofgabrielschulhof mentioned this pull request Jul 8, 2019
Closed
@nodejs-github-bot

nodejs-github-bot commented Jul 18, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24550/

mhdawson
mhdawson approved these changes Jul 23, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

Removing author ready because IIUC only @nodejs/backporters are supposed to land to 8.x-staging. Feel free to re-add if they are using author ready, but judging by the fact that this hasn't landed after 25 days with author ready applied, I'm guessing they're not. (Which is totally OK!)

@TrottTrott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2019
@legendecasGabriel Schulhof
n-api: make func argument of napi_create_threadsafe_function optional
d0a05d0
PR-URL: nodejs#27791
Refs: nodejs#27592
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof

gabrielschulhof commented Sep 2, 2019

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25576/

@BethGriggsBethGriggs added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 19, 2019
@gabrielschulhof

gabrielschulhof commented Oct 13, 2019

Copy link
Copy Markdown
ContributorAuthor

v8.x will receive no further minor versions.

@gabrielschulhof
gabrielschulhof deleted the backport-27791-to-v8.x branch October 13, 2019 07:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.node-apiIssues and PRs related to the Node-API.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gabrielschulhof@nodejs-github-bot@Trott@richardlau@legendecas@mhdawson@BethGriggs@BridgeAR