src: add errorProperties on process.report by himself65 · Pull Request #28426 · nodejs/node

himself65 · 2019-06-25T17:54:40Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

mmarchini · 2019-06-25T22:00:28Z

Thank you for working on this!

I wonder if this should be implemented on C++ instead though (using Object::GetOwnPropertyNames + Object::Get). Don't have strong opinions, but it would be nice to have the properties as a JSON object instead of a string though (and implementing in C++ would allow that).

nodejs-github-bot · 2020-03-11T06:39:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29718/

himself65 · 2020-03-15T15:50:43Z

fixed.

addaleax · 2020-03-27T14:57:25Z

@himself65 Could you rebase this?

himself65 · 2020-03-27T15:19:27Z

Rebased done, if CI passed

nodejs-github-bot · 2020-03-27T21:28:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30139/

jasnell · 2020-06-25T14:25:45Z

@himself65 ... unfortunately this needs another rebase

nodejs-github-bot · 2020-06-25T15:04:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32078/

nodejs-github-bot · 2020-06-25T19:42:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32090/

nodejs-github-bot · 2020-06-26T04:32:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32100/

nodejs-github-bot · 2020-06-26T06:06:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32101/

nodejs-github-bot · 2020-06-26T09:13:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32102/

jasnell · 2020-06-26T17:07:23Z

Landed in 870f0fc

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 25, 2019

himself65 force-pushed the 28415 branch 3 times, most recently from eb4e7cf to b236e8cCompare June 26, 2019 02:48

himself65 changed the title ~~src: add errorProperties on writeReport~~src: add errorProperties on process.reportJun 26, 2019

himself65 force-pushed the 28415 branch 6 times, most recently from 5e0527b to b7083e2Compare June 26, 2019 07:53

ZYSzys added the wip Issues and PRs that are still a work in progress. label Jun 26, 2019

himself65 force-pushed the 28415 branch 2 times, most recently from 0e8af53 to 7770f06Compare June 26, 2019 09:36

This comment has been minimized.
Sign in to view

himself65 marked this pull request as ready for review June 28, 2019 13:35

himself65 force-pushed the 28415 branch from c7d7035 to 6e869c8Compare June 28, 2019 13:35

This comment has been minimized.
Sign in to view

himself65 force-pushed the 28415 branch 2 times, most recently from 978f30e to 6a2f2e9Compare June 28, 2019 13:53

himself65 mentioned this pull request Jun 28, 2019
Diagnostics report: inspect the error object #28415
Closed

himself65 force-pushed the 28415 branch 7 times, most recently from 740ad5b to 919eba6Compare June 29, 2019 04:03

himself65 force-pushed the 28415 branch from ca954ac to 3bf3387Compare March 11, 2020 05:43

addaleax reviewed Mar 11, 2020
View reviewed changes

Comment threadsrc/node_report.cc Outdated
Comment threadsrc/node_report.cc Outdated
Comment threadsrc/node_report.cc Outdated

himself65 force-pushed the 28415 branch from 5526d87 to 55c5259Compare March 15, 2020 10:48

addaleax reviewed Mar 15, 2020
View reviewed changes

Comment threadsrc/node_report.cc Outdated

addaleax approved these changes Mar 15, 2020
View reviewed changes

jasnell approved these changes Mar 16, 2020
View reviewed changes

This comment has been minimized.
Sign in to view

himself65 added 2 commits June 26, 2020 00:26

src: add errorProperties on process.report
aee1485

test: check 'errorProperties' on report outputs
4a4d3df

github-actionsBot mentioned this pull request Jun 26, 2020
CI Relability 2020-06-26 JaneaSystems/nodejs-reliability#19
Open
13 tasks

Trott approved these changes Jun 26, 2020
View reviewed changes

This was referenced Jun 27, 2020
CI Relability 2020-06-27 JaneaSystems/nodejs-reliability#20
Open
CI Relability 2020-06-28 JaneaSystems/nodejs-reliability#21
Open

codebytere mentioned this pull request Jun 28, 2020
v14.5.0 proposal #34093
Merged

This was referenced Jun 29, 2020
CI Relability 2020-06-29 JaneaSystems/nodejs-reliability#22
Open
CI Relability 2020-06-30 JaneaSystems/nodejs-reliability#23
Open
CI Relability 2020-07-01 JaneaSystems/nodejs-reliability#24
Open

codebytere mentioned this pull request Jul 13, 2020
v12.18.3 proposal #34343
Merged

Uh oh!

Uh oh!

Conversation

himself65 commented Jun 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

mmarchini commented Jun 25, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Mar 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

himself65 commented Mar 15, 2020

Uh oh!

addaleax commented Mar 27, 2020

Uh oh!

This comment has been minimized.

himself65 commented Mar 27, 2020

Uh oh!

nodejs-github-bot commented Mar 27, 2020

Uh oh!

jasnell commented Jun 25, 2020

Uh oh!

nodejs-github-bot commented Jun 25, 2020

Uh oh!

nodejs-github-bot commented Jun 25, 2020

Uh oh!

nodejs-github-bot commented Jun 26, 2020

Uh oh!

nodejs-github-bot commented Jun 26, 2020

Uh oh!

nodejs-github-bot commented Jun 26, 2020

Uh oh!

jasnell commented Jun 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

himself65 commented Jun 25, 2019•
edited
Loading