Skip to content

test: fix flaky test-vm-timeout-escape-nexttick - #28461

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-flaky-escape-test
Closed

test: fix flaky test-vm-timeout-escape-nexttick#28461
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-flaky-escape-test

Conversation

@Trott

@TrottTrott commented Jun 27, 2019

Copy link
Copy Markdown
Member

Fixes: #24120

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@TrottTrott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jun 27, 2019
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 27, 2019
@Trott

Trott commented Jun 28, 2019

Copy link
Copy Markdown
MemberAuthor

node-stress-single-test isn't configured right now, so a stress test may have to wait unless I think of some other way to cajole a stress test out of CI....

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott

Trott commented Jun 28, 2019

Copy link
Copy Markdown
MemberAuthor

(Since this is a known_issues test, the flakiness problem is that it doesn't always fail. By looping, we make sure it fails. At least, that's the hope.)

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24135/

@danbev

danbev commented Jul 2, 2019

Copy link
Copy Markdown
Contributor

Landed in e008ca8.

@danbevdanbev closed this Jul 2, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott@targos
test: fix flaky test-vm-timeout-escape-nexttick
7665bad
PR-URL: #28461Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 2, 2019
@Trott@targos
test: fix flaky test-vm-timeout-escape-nexttick
8a64b70
PR-URL: #28461Fixes: #24120
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
@Trott
Trott deleted the fix-flaky-escape-test branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky known_issues/test-vm-timeout-escape-nexttick

5 participants

@Trott@nodejs-github-bot@danbev@jasnell@lpinca