Uh oh!
There was an error while loading. Please reload this page.
build: avoid building V8 snapshot if --without-snapshot - #28467
Closed
targos wants to merge 1 commit into
Closed
Conversation
devsnek
commented
Jun 28, 2019
Member
cc @joyeecheung |
nodejs-github-bot
commented
Jun 28, 2019
Collaborator
bnoordhuis
approved these changes
Jun 28, 2019
cjihrig
approved these changes
Jun 28, 2019
joyeecheung
approved these changes
Jun 28, 2019
joyeecheung
left a comment
Member
There was a problem hiding this comment.
nit for the commit message: “avoid building the default v8 snapshot...” for clarity (or maybe not, but when I saw the title I thought this was to make —without-snapshot imply —without-node-snapshot)
richardlau
approved these changes
Jun 28, 2019
nodejs-github-bot
commented
Jun 28, 2019
Collaborator
ryzokuken
approved these changes
Jun 28, 2019
refack
commented
Jun 28, 2019
Contributor
Refs: #27838 (comment) |
refack
reviewed
Jun 28, 2019
Contributor
There was a problem hiding this comment.
Can we de-dup this a little bit?
['v8_use_snapshot==1', {
'v8_lib_name': 'snapshot',
}, {
'v8_lib_name': 'nosnapshot',
}],
['GENERATOR == "ninja"', {
'obj_dir': '<(PRODUCT_DIR)/obj',
'v8_base': '<(PRODUCT_DIR)/obj/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
}, {
'obj_dir%': '<(PRODUCT_DIR)/obj.target',
'v8_base': '<(PRODUCT_DIR)/obj.target/tools/v8_gypfiles/libv8_<(v8_lib_name).a',
}],
['OS == "win"', {
'obj_dir': '<(PRODUCT_DIR)/obj',
'v8_base': '<(PRODUCT_DIR)/lib/libv8_<(v8_lib_name).a',
}],
['OS == "mac"', {
'obj_dir%': '<(PRODUCT_DIR)/obj.target',
'v8_base': '<(PRODUCT_DIR)/libv8_<(v8_lib_name).a',
}],
MemberAuthor
There was a problem hiding this comment.
gyp: Undefined variable v8_lib_name in /home/mzasso/git/nodejs/node/node.gyp while trying to load /home/mzasso/git/nodejs/node/node.gyp
hashseed
commented
Jun 29, 2019
Member
Fwiw we want to remove no snapshot builds from V8 by the end of this year. We are working on the blockers of that right now. Reason is that it now takes unreasonable amount of time to run without snapshot, and also doesn't match what we ship. |
targos
commented
Jun 29, 2019
MemberAuthor
That's good to know. We should probably remove or at least deprecate nosnapshot support in v13 then. |
nodejs-github-bot
commented
Jul 3, 2019
Collaborator
nodejs-github-bot
commented
Jul 6, 2019
Collaborator
Trott
approved these changes
Jul 6, 2019
nodejs-github-bot
commented
Jul 6, 2019
Collaborator
nodejs-github-bot
commented
Jul 6, 2019
Collaborator
targos
commented
Jul 6, 2019
MemberAuthor
The same tests failed three times in a row. It seems unlikely to be a flake, but they didn't fail in previous runs. I don't know what to do now... |
addaleax
commented
Jul 6, 2019
Member
|
It should be skipped if Node.js is built with the --without-snapshot configure flag.
targos
commented
Jul 12, 2019
MemberAuthor
I rebased on master and reworded the commit message. Maybe CI will pass now. |
nodejs-github-bot
commented
Jul 12, 2019
Collaborator
targos
commented
Jul 12, 2019
MemberAuthor
Landed in a8ed416 |
targos added a commit
that referenced
this pull request
Jul 12, 2019
It should be skipped if Node.js is built with the --without-snapshot configure flag. PR-URL: #28467 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit
that referenced
this pull request
Jul 20, 2019
It should be skipped if Node.js is built with the --without-snapshot configure flag. PR-URL: #28467 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @bnoordhuis@refack@ryzokuken