Skip to content

doc: simplify process.resourceUsage() section - #28499

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-process-resourceUsage
Closed

doc: simplify process.resourceUsage() section#28499
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-process-resourceUsage

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Jul 1, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge options list with its description to reduce redundancy (some possible typos were also fixed and some periods added).

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Jul 1, 2019
cjihrig
cjihrig approved these changes Jul 1, 2019
View reviewed changes
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
Comment threaddoc/api/process.md Outdated
@vsemozhetbyt
doc: simplify process.resourceUsage() section
b3671f7
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).
@nodejs-github-bot

nodejs-github-bot commented Jul 2, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24198/

@Trott

Trott commented Jul 2, 2019

Copy link
Copy Markdown
Member

Since this is a doc-only change, it just needs a lite CI. Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3732/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2019
@Trott

Trott commented Jul 4, 2019

Copy link
Copy Markdown
Member

Landed in 344d12c

@TrottTrott closed this Jul 4, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 4, 2019
@vsemozhetbyt@Trott
doc: simplify process.resourceUsage() section
344d12c
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).
PR-URL: nodejs#28499
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt
vsemozhetbyt deleted the doc-process-resourceUsage branch July 5, 2019 01:21
targos pushed a commit that referenced this pull request Jul 20, 2019
@vsemozhetbyt@targos
doc: simplify process.resourceUsage() section
29d2076
Merge options list with its description to reduce redundancy
(some possible typos were also fixed and some periods added).
PR-URL: #28499
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vsemozhetbyt@nodejs-github-bot@Trott@lpinca@cjihrig@gengjiawen@BridgeAR@trivikr