Skip to content

src: remove unused using declarations in src/api - #28506

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:src-api-unused-using
Closed

src: remove unused using declarations in src/api#28506
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:src-api-unused-using

Conversation

@danbev

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 2, 2019
@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbevdanbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@danbev
danbevforce-pushed the src-api-unused-using branch from 1a2437d to 5af9d55CompareJuly 5, 2019 04:56
@danbev

Copy link
Copy Markdown
ContributorAuthor

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in 901343f.

@danbevdanbev closed this Jul 5, 2019
@danbev
danbev deleted the src-api-unused-using branch July 5, 2019 06:40
targos pushed a commit that referenced this pull request Jul 20, 2019
PR-URL: #28506
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants

@danbev@nodejs-github-bot@Trott@addaleax@lpinca@targos@cjihrig@gengjiawen@richardlau@BridgeAR