Uh oh!
There was an error while loading. Please reload this page.
test: add test-fs-writeFileSync-invalid-windows - #28569
Merged
Merged
Conversation
nodejs-github-bot
commented
Jul 5, 2019
Collaborator
cjihrig
approved these changes
Jul 6, 2019
lpinca
approved these changes
Jul 9, 2019
lpinca
commented
Jul 9, 2019
Member
Why it fails when skipped? |
Trott
commented
Jul 10, 2019
MemberAuthor
Because |
nodejs-github-bot
commented
Jul 10, 2019
Collaborator
BridgeAR
approved these changes
Jul 11, 2019
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL is more appropriate. This happens with various functions in the `fs` module when an invalid path is used. Refs: nodejs#8987 PR-URL: nodejs#28569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott
commented
Jul 11, 2019
MemberAuthor
Landed in b6e301a |
targos pushed a commit
that referenced
this pull request
Jul 20, 2019
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL is more appropriate. This happens with various functions in the `fs` module when an invalid path is used. Refs: #8987 PR-URL: #28569 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a known_issues test for the Windows returning ENOTFOUND where EINVAL
is more appropriate. This happens with various functions in the
fsmodule when an invalid path is used.
Refs: #8987
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes