Skip to content

doc: edit stream module introduction - #28595

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:update-stream-intro
Jul 12, 2019
Merged

doc: edit stream module introduction#28595
Trott merged 1 commit into
nodejs:masterfrom
Trott:update-stream-intro

Conversation

@Trott

@TrottTrott commented Jul 8, 2019

Copy link
Copy Markdown
Member

Edit the stream module introduction for concision and simplicity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 8, 2019
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2019
@Trott

This comment has been minimized.

@Trott

Trott commented Jul 8, 2019

Copy link
Copy Markdown
MemberAuthor

Edit the stream module introduction for concision and simplicity.
PR-URL: nodejs#28595
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Trott commented Jul 12, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 86f8f4f.

@Trott
Trottforce-pushed the update-stream-intro branch from 0b744ec to 86f8f4fCompareJuly 12, 2019 05:57
@Trott
Trott merged commit 86f8f4f into nodejs:masterJul 12, 2019
@Trott
Trott deleted the update-stream-intro branch July 12, 2019 05:59
targos pushed a commit that referenced this pull request Jul 20, 2019
Edit the stream module introduction for concision and simplicity.
PR-URL: #28595
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 23, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@lpinca@cjihrig@BridgeAR@trivikr@ZYSzys@nodejs-github-bot