Uh oh!
There was an error while loading. Please reload this page.
doc: mention unit for event loop delay measurements - #28629
Closed
hybrist wants to merge 1 commit into
Closed
Conversation
bcoe
approved these changes
Jul 10, 2019
bcoe
left a comment
Contributor
There was a problem hiding this comment.
👍 I found the lack of unit confusing, might be worth adding notes about units in a few more places. but, I fully endorse this clarification being added.
cjihrig
approved these changes
Jul 10, 2019
addaleax
approved these changes
Jul 10, 2019
gireeshpunathil
approved these changes
Jul 11, 2019
nodejs-github-bot
commented
Jul 11, 2019
Collaborator
BridgeAR
approved these changes
Jul 11, 2019
hybrist
commented
Jul 11, 2019
ContributorAuthor
Given the size of the change and the lack of disagreement, I hereby apply for fast-tracking. :) |
pullBot
pushed a commit
to tkamenoko/node
that referenced
this pull request
Jul 11, 2019
PR-URL: nodejs#28629 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
commented
Jul 11, 2019
Member
Landed in ca0884a |
targos pushed a commit
that referenced
this pull request
Jul 20, 2019
PR-URL: #28629 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist