Skip to content

http: refactor keep alive - #28700

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http-refactor-keep-alive
Closed

http: refactor keep alive#28700
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http-refactor-keep-alive

Conversation

@ronag

@ronagronag commented Jul 15, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation.

Also minor perf improvement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 15, 2019
@ronagronag changed the title Http refactor keep alivehttp: refactor keep aliveJul 15, 2019
@ronag
ronagforce-pushed the http-refactor-keep-alive branch 5 times, most recently from 71d9bb8 to 6e0f839CompareJuly 15, 2019 17:46
@ronagronag mentioned this pull request Jul 15, 2019
Closed
@ronag

ronag commented Jul 18, 2019

Copy link
Copy Markdown
MemberAuthor

ping @benjamingr

benjamingr
benjamingr approved these changes Jul 18, 2019
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a readability improvement IMO and it makes more sense for the destroySoon stuff to happen in the responseEnd and not responseKeepAlive method.

Thanks for this 🙏

@Trott

Trott commented Jul 18, 2019

Copy link
Copy Markdown
Member

@nodejs/http While not strictly necessary, another review or two here would be good.

@mcollina

mcollina commented Aug 28, 2019

Copy link
Copy Markdown
Member

This would need a rebase.

mcollina
mcollina approved these changes Aug 28, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25282/

@ronag
ronagforce-pushed the http-refactor-keep-alive branch 2 times, most recently from 350b4d7 to 625a60aCompareAugust 28, 2019 08:48
@ronag

ronag commented Aug 28, 2019

Copy link
Copy Markdown
MemberAuthor

rebased

@benjamingrbenjamingr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 28, 2019
@mcollina

mcollina commented Aug 30, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1988/

@mcollina

mcollina commented Sep 8, 2019

Copy link
Copy Markdown
Member

Unfortunately it needs another rebase :(

@ronag

ronag commented Sep 8, 2019

Copy link
Copy Markdown
MemberAuthor

Rebased

@ronag
ronagforce-pushed the http-refactor-keep-alive branch from 625a60a to 51b9daaCompareSeptember 8, 2019 14:54
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25395/

@mcollina

mcollina commented Sep 8, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1996/

@mcollina

mcollina commented Sep 10, 2019

Copy link
Copy Markdown
Member

CITGM is ok.

@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25446/

@mcollina

mcollina commented Sep 13, 2019

Copy link
Copy Markdown
Member

There seems to be CI failures on specific environments... cc @Trott.

@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25469/

@Trott

Trott commented Sep 16, 2019

Copy link
Copy Markdown
Member

Landed in 627bb6b

Trott pushed a commit that referenced this pull request Sep 16, 2019
@ronag@Trott
http: refactor responseKeepAlive()
627bb6b
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.
Also minor perf improvement.
PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott closed this Sep 16, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
@ronag@targos
http: refactor responseKeepAlive()
e75661e
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.
Also minor perf improvement.
PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@ronag@BridgeAR
http: refactor responseKeepAlive()
31b0b52
This tries to simplify the code and make it easier to understand. Took
me a while to get my head around the previous implementation.
Also minor perf improvement.
PR-URL: #28700
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@Trott@mcollina@nodejs-github-bot@jasnell@benjamingr@trivikr