Uh oh!
There was an error while loading. Please reload this page.
test: export public symbols in addons tests - #28717
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Jul 16, 2019
Collaborator
Trott
approved these changes
Jul 16, 2019
cjihrig
approved these changes
Jul 16, 2019
jasnell
approved these changes
Jul 17, 2019
Trott
commented
Jul 18, 2019
Member
Relevant CI failures....I'll put a |
nodejs-github-bot
commented
Jul 28, 2019
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR
commented
Jan 12, 2020
Member
What's the status here? |
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: nodejs#28647 Refs: nodejs/node-gyp#1828
nodejs-github-bot
commented
Jan 12, 2020
Collaborator
BridgeAR
commented
Jan 12, 2020
Member
bnoordhuis
commented
Jan 12, 2020
MemberAuthor
I don't think that's related. The stack trace is for |
addaleax
approved these changes
Jan 12, 2020
nodejs-github-bot
commented
Jan 12, 2020
Collaborator
Trott
commented
Jan 18, 2020
Member
Landed in cc0748f |
Trott pushed a commit
that referenced
this pull request
Jan 18, 2020
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: #28647 Refs: nodejs/node-gyp#1828 PR-URL: #28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau
commented
Jan 18, 2020
Member
That’s failing the same CHECK as #31061 so probably indicates the test is reusing addresses for BackingStore which is no longer allowed. |
codebytere pushed a commit
that referenced
this pull request
Feb 17, 2020
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: #28647 Refs: nodejs/node-gyp#1828 PR-URL: #28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
codebytere pushed a commit
that referenced
this pull request
Mar 14, 2020
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: #28647 Refs: nodejs/node-gyp#1828 PR-URL: #28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit
that referenced
this pull request
Mar 17, 2020
Upcoming changes to node-gyp will turn on `-fvisibility=hidden` on macOS. Ensure that public symbols that are dlsym'd have default visibility. Refs: #28647 Refs: nodejs/node-gyp#1828 PR-URL: #28717 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upcoming changes to node-gyp will turn on
-fvisibility=hiddenonmacOS. Ensure that public symbols that are dlsym'd have default
visibility.
Refs: #28647
Refs: nodejs/node-gyp#1828