Uh oh!
There was an error while loading. Please reload this page.
[v10.x backport] tools: replace rollup with ncc - #28736
Closed
Trott wants to merge 1 commit into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Replace rollup + plugins + config file with zeit/ncc package designed to do the particular task that we're leveraging rollup for but with zero-ish configuration. (rollup can do a whole lot more, but we're using a tiny portion of its functionality.) PR-URL: nodejs#24813 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: nodejs#28736
Trott
commented
Jul 17, 2019
MemberAuthor
OK, fixed. (I should have done an |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jul 19, 2019
Collaborator
nodejs-github-bot
commented
Jul 20, 2019
Collaborator
nodejs-github-bot
commented
Jul 21, 2019
Collaborator
nodejs-github-bot
commented
Jul 21, 2019
Collaborator
nodejs-github-bot
commented
Jul 21, 2019
Collaborator
Trott
commented
Jul 21, 2019
MemberAuthor
The persistent AIX CI failures are surely unrelated and I guess suggest that there's some fix for AIX on master that has not yet landed on v10.x-staging? /ping @nodejs/platform-aix |
richardlau
commented
Jul 21, 2019
Member
At least #28600 hasn’t made it back yet. |
Trott
commented
Jul 25, 2019
MemberAuthor
CI will be red on this until #28826 lands, but then this should be good to go. |
Collaborator
BethGriggs
approved these changes
Jul 25, 2019
BethGriggs pushed a commit
that referenced
this pull request
Jul 25, 2019
Replace rollup + plugins + config file with zeit/ncc package designed to do the particular task that we're leveraging rollup for but with zero-ish configuration. (rollup can do a whole lot more, but we're using a tiny portion of its functionality.) PR-URL: #24813 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: #28736
BethGriggs
commented
Jul 25, 2019
Member
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace rollup + plugins + config file with zeit/ncc package designed to
do the particular task that we're leveraging rollup for but with
zero-ish configuration. (rollup can do a whole lot more, but we're using
a tiny portion of its functionality.)
PR-URL: #24813
Reviewed-By: Guy Bedford guybedford@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
@BethGriggs
Backport of #24813