Uh oh!
There was an error while loading. Please reload this page.
build: generate openssl config for BSD-x86 - #28806
Closed
bnoordhuis wants to merge 1 commit into
Closed
Conversation
Add BSD-x86 to the list of arches and regenerate everything. Everything in deps/openssl/config/archs/BSD-x86 is auto-generated, everything else is manual edits to include the right files in the right places. I cheated a little: I didn't check in changes to files for other arches because they contained mostly churn (updated buildstamps and such.) Fixes: nodejs#20326
nodejs-github-bot
commented
Jul 22, 2019
Collaborator
nodejs-github-bot
commented
Jul 24, 2019
Collaborator
Trott
commented
Jul 24, 2019
Member
@nodejs/crypto |
Trott
commented
Jul 25, 2019
Member
@nodejs/platform-freebsd |
sam-github
commented
Jul 25, 2019
Contributor
Trott
commented
Jul 30, 2019
Member
Technically, this can land (1 approval, more than 7 days open, passing CI) but another review would be nice, especially if it's a little more thorough than my rubber-stamp. @nodejs/collaborators |
emaste
commented
Jul 30, 2019
LGTM |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 30, 2019
Add BSD-x86 to the list of arches and regenerate everything. Everything in deps/openssl/config/archs/BSD-x86 is auto-generated, everything else is manual edits to include the right files in the right places. I cheated a little: I didn't check in changes to files for other arches because they contained mostly churn (updated buildstamps and such.) Fixes: nodejs#20326 PR-URL: nodejs#28806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jul 30, 2019
Member
Landed in 4a1502b. |
Trott
commented
Jul 30, 2019
Member
(node-daily-master is green.) |
targos pushed a commit
that referenced
this pull request
Aug 2, 2019
Add BSD-x86 to the list of arches and regenerate everything. Everything in deps/openssl/config/archs/BSD-x86 is auto-generated, everything else is manual edits to include the right files in the right places. I cheated a little: I didn't check in changes to files for other arches because they contained mostly churn (updated buildstamps and such.) Fixes: #20326 PR-URL: #28806 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BSD-x86 to the list of arches and regenerate everything.
Everything in deps/openssl/config/archs/BSD-x86 is auto-generated,
everything else is manual edits to include the right files in the
right places.
I cheated a little: I didn't check in changes to files for other arches
because they contained mostly churn (updated buildstamps and such.)
Fixes: #20326