Skip to content

module: unify package exports test for CJS and ESM - #28831

Closed
hybrist wants to merge 1 commit into
nodejs:masterfrom
hybrist:one-exports-test
Closed

module: unify package exports test for CJS and ESM#28831
hybrist wants to merge 1 commit into
nodejs:masterfrom
hybrist:one-exports-test

Conversation

@hybrist

@hybristhybrist commented Jul 24, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: nodejs/modules#358

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 24, 2019
@hybristhybrist added esm Issues and PRs related to the ECMAScript Modules implementation. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. labels Jul 24, 2019
hybrist
hybrist commented Jul 24, 2019
View reviewed changes
Comment threadsrc/module_wrap.cc Outdated
hybrist
hybrist commented Jul 24, 2019
View reviewed changes
Comment threadtest/common/index.mjs Outdated
@hybristhybrist changed the title module: unify test suite for CJS and ESMmodule: unify package exports test for CJS and ESMJul 24, 2019
guybedford
guybedford approved these changes Jul 24, 2019
View reviewed changes

@guybedfordguybedford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have unified tests indeed.

Comment threadsrc/module_wrap.cc Outdated
Comment threadsrc/module_wrap.cc Outdated
Comment threadtest/common/index.mjs Outdated
Comment threadtest/fixtures/node_modules/pkgexports/package.json Outdated
@hybrist

hybrist commented Jul 24, 2019

Copy link
Copy Markdown
ContributorAuthor

/cc @nodejs/modules-active-members

@hybristhybrist mentioned this pull request Jul 24, 2019
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 26, 2019•
edited by Trott
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24724/ ✔️

@hybristhybrist added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 26, 2019
@hybristhybrist mentioned this pull request Jul 29, 2019
Closed
@Trott

Trott commented Jul 30, 2019

Copy link
Copy Markdown
Member

This could use more reviews. @nodejs/collaborators

@guybedford

guybedford commented Jul 31, 2019

Copy link
Copy Markdown
Contributor

More approvals would be great, but this should still be good to merge given the 7 days now I believe.

gengjiawen
gengjiawen reviewed Jul 31, 2019
View reviewed changes
Comment threadtest/message/async_error_sync_esm.out
Trott
Trott requested changes Jul 31, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abort/test-addon-uv-handle-leak is failing locally for me with this change. Will re-run CI while I investigate locally.... Could be something incompatible slipped in while this PR was baking....

@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24801/

@Trott

Trott commented Jul 31, 2019

Copy link
Copy Markdown
Member

Looks like I just needed to do a more thorough rebuild to catch up my addons. I think this is good although out of caution, I'll wait for the CI re-run results.

@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24802/

@Trott

Trott commented Jul 31, 2019

Copy link
Copy Markdown
Member

Landed in 61f3a5c

@TrottTrott closed this Jul 31, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 31, 2019
@hybrist@Trott
module: unify package exports test for CJS and ESM
61f3a5c
Refs: nodejs/modules#358
PR-URL: nodejs#28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 2, 2019
@hybrist@targos
module: unify package exports test for CJS and ESM
d9084d2
Refs: nodejs/modules#358
PR-URL: #28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeARBridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guybedfordguybedfordguybedford approved these changes
@gengjiawengengjiawengengjiawen left review comments
@TrottTrottTrott approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.esmIssues and PRs related to the ECMAScript Modules implementation.moduleIssues and PRs related to the module subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hybrist@nodejs-github-bot@Trott@guybedford@gengjiawen