[v10.x] console: add trace-events for time and count by andrewhughes101 · Pull Request #28840 · nodejs/node

andrewhughes101 · 2019-07-24T10:40:44Z

Add the node.console trace event category to capture
console.count(), console.countReset(), console.time(),
console.timeLog(), and console.timeEnd() to the trace
event log.

PR-URL: #23703
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Richard Lau riclau@uk.ibm.com

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2019-07-24T10:42:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24658/

mhdawson

LGTM

nodejs-github-bot · 2020-02-25T14:19:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29344/

Only failure was test.parallel/test-bootstrap-modules on https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12419/console

BethGriggs · 2020-03-03T16:37:01Z

@andrewhughes101, based on the history of this test on v10.x I think the module count number should be incremented by 1 in parallel/test-bootstrap-modules

Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: nodejs#23703 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

nodejs-github-bot · 2020-03-04T13:31:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29534/ ✅ - CI is known OSX failures from adding 10.15

Add the `node.console` trace event category to capture `console.count()`, `console.countReset()`, `console.time()`, `console.timeLog()`, and `console.timeEnd()` to the trace event log. PR-URL: #23703 Backport-PR-URL: #28840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

BethGriggs · 2020-03-09T11:30:29Z

Landed in b164a2e

nodejs-github-bot added console Issues and PRs related to the console subsystem. v10.x labels Jul 24, 2019

BethGriggs approved these changes Jul 24, 2019
View reviewed changes