Uh oh!
There was an error while loading. Please reload this page.
[v10.x] src: reduce platform worker barrier lifetime - #28844
Closed
andrewhughes101 wants to merge 1 commit into
Closed
[v10.x] src: reduce platform worker barrier lifetime#28844andrewhughes101 wants to merge 1 commit into
andrewhughes101 wants to merge 1 commit into
Conversation
ofrobots
approved these changes
Jul 24, 2019
ofrobots
left a comment
Contributor
There was a problem hiding this comment.
LGTM w/ a minor style nit
Contributor
There was a problem hiding this comment.
style nit: trailing whitespace
ContributorAuthor
There was a problem hiding this comment.
Hi I took this out because it fails the linter
src/node_platform.cc:172: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]Done processing src/node_platform.ccofrobots
commented
Jul 24, 2019
Contributor
BTW, is there a motivating for making this change on |
andrewhughes101
commented
Jul 25, 2019
ContributorAuthor
I was looking for a good first contribution so went through the |
BethGriggs
approved these changes
Jul 25, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Minor cleanup in the lifetime for the platform worker initialization synchronization barrier. PR-URL: nodejs#23419 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
andrewhughes101force-pushed
the
backport-23419-to-v10.x
branch
from
July 29, 2019 11:01
e4a0efe to
c713f35Comparenodejs-github-bot
commented
Jul 29, 2019
Collaborator
Collaborator
BethGriggs pushed a commit
that referenced
this pull request
Sep 20, 2019
Minor cleanup in the lifetime for the platform worker initialization synchronization barrier. PR-URL: #23419 Backport-PR-URL: #28844 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
commented
Sep 20, 2019
Member
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes