Uh oh!
There was an error while loading. Please reload this page.
doc: fixup esm resolver spec formatting - #28885
Closed
guybedford wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Jul 29, 2019
targos
approved these changes
Jul 29, 2019
targos
commented
Jul 29, 2019
Member
👍 to fast-track |
jasnell
approved these changes
Jul 29, 2019
lpinca
approved these changes
Jul 29, 2019
nodejs-github-bot
commented
Jul 29, 2019
Collaborator
guybedford
commented
Jul 30, 2019
ContributorAuthor
Landed in 816db9e. |
guybedford added a commit
that referenced
this pull request
Jul 30, 2019
PR-URL: #28885 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28885 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up the formatting of the esm resolver spec in the docs, which is currently showing some markdown issues - https://nodejs.org/dist/latest-v12.x/docs/api/esm.html#esm_resolution_algorithm.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes