Uh oh!
There was an error while loading. Please reload this page.
doc: Include "exports" resolver specification - #28899
Closed
guybedford wants to merge 5 commits into
Closed
Conversation
hybrist
requested changes
Jul 30, 2019
hybrist
left a comment
Contributor
There was a problem hiding this comment.
One nit about the non-object edge case. Other LGTM.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
guybedford
commented
Jul 30, 2019
ContributorAuthor
@jkrems I believe I've adjusted it to the implementation now, thanks. |
hybrist
approved these changes
Jul 30, 2019
Trott
approved these changes
Aug 1, 2019
Trott
commented
Aug 1, 2019
Member
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3817/ (scheduled--Jenkins is going down but presumably the CI job will kick off when it's back up) |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2019
PR-URL: nodejs#28899 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Aug 1, 2019
Member
Landed in 8492acf |
targos pushed a commit
that referenced
this pull request
Aug 2, 2019
PR-URL: #28899 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This amends the ES module resolver specification in the documentation to include the behaviour of the "exports" feature as implemented and merged in #28568.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes