Uh oh!
There was an error while loading. Please reload this page.
http2: destroy when call settingsFn throw an error - #28908
Closed
himself65 wants to merge 2 commits into
Closed
Conversation
lpinca
approved these changes
Jul 31, 2019
Uh oh!
There was an error while loading. Please reload this page.
himself65force-pushed
the
28895
branch
6 times, most recently
from
August 1, 2019 06:50
52cde56 to
f8371b2Comparehimself65
commented
Aug 1, 2019
MemberAuthor
done |
trivikr
approved these changes
Aug 1, 2019
jasnell
approved these changes
Aug 1, 2019
nodejs-github-bot
commented
Aug 2, 2019
Collaborator
Trott
approved these changes
Aug 2, 2019
Trott
commented
Aug 2, 2019
Member
Landed in 2b03e1d |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2019
http2.connect should call destroy when init fails. PR-URL: nodejs#28908 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 2, 2019
http2.connect should call destroy when init fails. PR-URL: #28908 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix#28895
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes