Skip to content

doc: remove legacy mode deprecation in assert - #28909

Merged
Trott merged 0 commit into
nodejs:masterfrom
Trott:remove-from-docs
Aug 2, 2019
Merged

doc: remove legacy mode deprecation in assert#28909
Trott merged 0 commit into
nodejs:masterfrom
Trott:remove-from-docs

Conversation

@Trott

@TrottTrott commented Jul 31, 2019

Copy link
Copy Markdown
Member

The deprecation was revoked in
#28892.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 31, 2019
@Trott
Trott requested a review from cjihrigJuly 31, 2019 17:32
@Trott

Trott commented Jul 31, 2019

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3815/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2019
@TrottTrott closed this Aug 2, 2019
@Trott

Trott commented Aug 2, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 36864a6

@Trott
Trott deleted the remove-from-docs branch August 2, 2019 19:00
@Trott
Trott merged commit 36864a6 into nodejs:masterAug 2, 2019
targos pushed a commit that referenced this pull request Aug 2, 2019
@Trott@targos
doc: remove legacy mode deprecation in assert
f4abf17
The deprecation was revoked in
#28892.
PR-URL: #28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Aug 6, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@silverwindsilverwindsilverwind approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@silverwind@jasnell@lpinca@cjihrig@trivikr@nodejs-github-bot