stream: writableComplete

[ronag]

This is just a suggestion. Would like to see if there is any traction behind it.

It is quite common (at least in http and middleware) to check whether any further useful work can be performed on a writable stream. This is a bit similar to onFinished.isFinished.

We also already have it here: https://github.com/nodejs/node/blob/master/lib/internal/http2/compat.js#L304

Replaces #28628

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

ping @mcollina thoughts?

[mcollina]

I'm not sure about this one. I think writableFinished and destroyed provides this same capability. Why would we need this?

[ronag]

@mcollina: Convenience. Also the check is a bit more complicated on the http side of things. Not sure if there is a good user space way to check it there.

[Trott]

@nodejs/streams

[mcollina]

I'm -1 of adding this, as that state data is already exposed in other accessors

[ronag]

There is something with http here that might need further thinking but I can't remember what it was. Will close for now.