Uh oh!
There was an error while loading. Please reload this page.
stream: buffer-list encapsulation - #28974
Closed
ronag wants to merge 1 commit into
Closed
Conversation
ronagforce-pushed
the
stream-buffer-list
branch
6 times, most recently
from
August 5, 2019 11:32
b33fec8 to
324b965Compareaddaleax
approved these changes
Aug 5, 2019
nodejs-github-bot
commented
Aug 5, 2019
Collaborator
lpinca
reviewed
Aug 5, 2019
Member
There was a problem hiding this comment.
Is this as fast as the original loop?
MemberAuthor
There was a problem hiding this comment.
I don't know... trying to figure out the whole benchmark thing at the moment
MemberAuthor
There was a problem hiding this comment.
streams/readable-readall.js n=200 0.67 % ±3.32% ±4.42% ±5.77%
ronagforce-pushed
the
stream-buffer-list
branch
3 times, most recently
from
August 6, 2019 09:13
7497bf0 to
2a729ceComparejasnell
approved these changes
Aug 7, 2019
lpinca
approved these changes
Aug 7, 2019
Trott
commented
Aug 8, 2019
Member
@nodejs/streams |
mcollina
requested changes
Aug 9, 2019
mcollina
left a comment
Member
There was a problem hiding this comment.
Would you mind adding a unit test of the iterator in test-stream-buffer-list.js?
ronag
commented
Aug 9, 2019
MemberAuthor
test updated |
nodejs-github-bot
commented
Aug 9, 2019
Collaborator
ronag
commented
Aug 9, 2019
MemberAuthor
needed a master rebase + |
nodejs-github-bot
commented
Aug 9, 2019
Collaborator
Trott
approved these changes
Aug 9, 2019
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 9, 2019
PR-URL: nodejs#28974 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Aug 9, 2019
Member
Landed in c15b496 |
targos pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #28974 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Aug 20, 2019
dave-kennedy
commented
Sep 14, 2019
Is this intended to be used in place of something like bl? |
mcollina
commented
Sep 14, 2019
Member
Not really, BufferList is not really documented API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only use public API on buffer list to improve encapsulation and make it easier to experiment with alternative implementations.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes