Uh oh!
There was an error while loading. Please reload this page.
[v10.x] deps:openssl: cherry-pick c19c5a6 from upstream - #28983
Closed
ofrobots wants to merge 1 commit into
Closed
Conversation
Original commit message: Revert the DEVRANDOM_WAIT feature The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b8 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on the performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes 9078 This partially reverts commit 38023b8. Refs: openssl/openssl#9084Fixes: nodejs#28932
nodejs-github-bot
commented
Aug 5, 2019
Collaborator
ofrobots
commented
Aug 5, 2019
ContributorAuthor
@nodejs/lts @nodejs/crypto this needs a review, but otherwise good to go. CI is green. |
shigeki
approved these changes
Aug 6, 2019
shigeki
left a comment
Contributor
There was a problem hiding this comment.
LGTM but it means that Google Cloud needs to have more entropies as
the platform maintainer to ensure a proper initialization during early boot time.
https://github.com/openssl/openssl/blob/f2bb79a78a1681f9a137d7560a17982f6e54333c/CHANGES#L37-L38
addaleax
approved these changes
Aug 6, 2019
BethGriggs
approved these changes
Aug 6, 2019
bnoordhuis
approved these changes
Aug 6, 2019
cjihrig
approved these changes
Aug 6, 2019
BethGriggs pushed a commit
that referenced
this pull request
Aug 6, 2019
Original commit message: Revert the DEVRANDOM_WAIT feature The DEVRANDOM_WAIT feature added a select() call to wait for the `/dev/random` device to become readable before reading from the `/dev/urandom` device. It was introduced in commit 38023b8 in order to mitigate the fact that the `/dev/urandom` device does not block until the initial seeding of the kernel CSPRNG has completed, contrary to the behaviour of the `getrandom()` system call. It turned out that this change had negative side effects on the performance which were not acceptable. After some discussion it was decided to revert this feature and leave it up to the OS resp. the platform maintainer to ensure a proper initialization during early boot time. Fixes 9078 This partially reverts commit 38023b8. Refs: openssl/openssl#9084Fixes: #28932 PR-URL: #28983 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
commented
Aug 6, 2019
Contributor
landed in 894a9dd |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: openssl/openssl#9084
Fixes: #28932
make -j4 test(UNIX), orvcbuild test(Windows) passes