Uh oh!
There was an error while loading. Please reload this page.
test: async iterate destroyed stream - #28995
Closed
ronag wants to merge 1 commit into
Closed
Conversation
MemberAuthor
@mcollina: Should this maybe result in a |
mcollina
commented
Aug 6, 2019
Member
Would you mind adding a unit test? |
7 tasks
ronag
commented
Aug 6, 2019
MemberAuthor
This would be fixed by and is blocked by #28748 |
ronag
commented
Aug 6, 2019
MemberAuthor
Added test. |
ronagforce-pushed
the
stream-async-iterator-destroyed
branch
3 times, most recently
from
August 6, 2019 11:04
4a18e90 to
39594eeCompareaddaleax
approved these changes
Aug 6, 2019
trivikr
commented
Aug 6, 2019
Member
Should subsystem be |
ronag
commented
Aug 6, 2019
MemberAuthor
ronag
commented
Aug 24, 2019
MemberAuthor
@Trott: blocked label? |
ronagforce-pushed
the
stream-async-iterator-destroyed
branch
from
September 23, 2019 07:39
39594ee to
029fe89CompareMemberAuthor
renamed into "test" scope |
ronagforce-pushed
the
stream-async-iterator-destroyed
branch
3 times, most recently
from
September 24, 2019 21:06
bed5ced to
0d6ba10Compareronagforce-pushed
the
stream-async-iterator-destroyed
branch
from
September 24, 2019 21:06
0d6ba10 to
87c5750Comparejasnell
approved these changes
Sep 25, 2019
ronag
commented
Sep 25, 2019
MemberAuthor
@Trott: this is no longer blocked |
trivikr
approved these changes
Sep 26, 2019
ronag
commented
Nov 11, 2019
MemberAuthor
nodejs-github-bot
commented
Feb 14, 2020
Collaborator
nodejs-github-bot
commented
Feb 14, 2020
Collaborator
ronag added a commit
that referenced
this pull request
Feb 14, 2020
PR-URL: #28995 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
ronag
commented
Feb 14, 2020
MemberAuthor
Landed in df1592d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we will deadlock on destroyed streams...
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes