Uh oh!
There was an error while loading. Please reload this page.
[x] stream: async iterate don't register listeners if ended - #28996
Closed
ronag wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 6, 2019
Closed
addaleax
commented
Aug 6, 2019
Member
Can you add a test? |
ronag
commented
Aug 28, 2019
MemberAuthor
closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't register listeners if stream is already "ended".
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes