Uh oh!
There was an error while loading. Please reload this page.
http: replace superfluous property with getter/setter - #29015
Closed
ronag wants to merge 1 commit into
Closed
Conversation
addaleax
approved these changes
Aug 6, 2019
mscdex
commented
Aug 6, 2019
Contributor
AFAIK getters/setters like this incur noticeable overhead, so perhaps we should be adjusting the documentation to more strongly recommend |
mscdex
commented
Aug 6, 2019
Contributor
Also if we're making this change we should also replace all usage of |
ronagforce-pushed
the
http-connection
branch
2 times, most recently
from
August 6, 2019 12:51
551d5ec to
9fe52d4Compareronag
commented
Aug 6, 2019
MemberAuthor
@mscdex better? |
ronagforce-pushed
the
http-connection
branch
7 times, most recently
from
August 6, 2019 13:56
c16f5f6 to
80a07daComparetrivikr
reviewed
Aug 6, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jasnell
approved these changes
Aug 7, 2019
trivikr
approved these changes
Aug 7, 2019
lpinca
approved these changes
Aug 9, 2019
ronag
commented
Aug 17, 2019
MemberAuthor
@Trott: this seems ready |
nodejs-github-bot
commented
Aug 17, 2019
Collaborator
Trott
approved these changes
Aug 17, 2019
Trott
commented
Aug 17, 2019
Member
Landed in 0daec61 |
This was referenced Jan 20, 2021
This was referenced Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly reduces memory overhead by replacing superfluous property with getter/setter.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes