Skip to content

[x] stream: simplify writable buffering - #29026

Closed
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:stream-writable-buffered
Closed

[x] stream: simplify writable buffering#29026
ronag wants to merge 4 commits into
nodejs:masterfrom
nxtedition:stream-writable-buffered

Conversation

@ronag

@ronagronag commented Aug 6, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This simplifies the buffering logic in writable_stream and makes it easier to maintain and possiblinly optimize. Also minor speed and memory overhead optimisation.

I have a few ideas on how to further optimize this. But as a first step, simplify while maintaining current performance.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
 streams/writable-manywrites.js n=2000000 4.05 % ±4.69% ±6.24% ±8.13%

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Aug 6, 2019
@ronag
ronagforce-pushed the stream-writable-buffered branch from 03b2e7d to 44f11c9CompareAugust 6, 2019 19:47
@ronagronag changed the title stream: refactor writable bufferingstream: simplify writable bufferingAug 6, 2019
@ronag
ronagforce-pushed the stream-writable-buffered branch 6 times, most recently from 86b6936 to 62b056cCompareAugust 6, 2019 20:10
@ronag

ronag commented Aug 6, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Future TODO is to merge with #29028

@ronag
ronagforce-pushed the stream-writable-buffered branch 18 times, most recently from f5200a9 to 66056beCompareAugust 9, 2019 16:02
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24910/

@ronagronag mentioned this pull request Aug 25, 2019
Closed
mscdex
mscdex reviewed Aug 25, 2019
View reviewed changes
Comment threadlib/_stream_writable.js Outdated
mscdex
mscdex reviewed Aug 25, 2019
View reviewed changes
Comment threadlib/_stream_writable.js Outdated
mscdex
mscdex reviewed Aug 25, 2019
View reviewed changes
Comment threadlib/_stream_writable.js Outdated
@ronag
ronagforce-pushed the stream-writable-buffered branch from 66056be to c09f94cCompareAugust 25, 2019 20:10
@ronag

ronag commented Aug 25, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott: those travis errors look strange, what's going on?

@nodejs-github-bot

nodejs-github-bot commented Aug 25, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25238/

@Trott

Trott commented Aug 25, 2019

Copy link
Copy Markdown
Member

@Trott: those travis errors look strange, what's going on?

Not sure but if it's not happening on Jenkins, I wouldn't worry about it. I just started the tests on Jenkins so let's see what happens...

mscdex
mscdex reviewed Aug 26, 2019
View reviewed changes
Comment threadlib/_stream_writable.js Outdated
mscdex
mscdex reviewed Aug 26, 2019
View reviewed changes
Comment threadlib/_stream_writable.js Outdated
@ronag@mscdex
Apply suggestions from code review
dcc9bf2
Co-Authored-By: mscdex <mscdex@users.noreply.github.com>
@ronagronag changed the title stream: simplify writable buffering[x] stream: simplify writable bufferingAug 28, 2019
@ronag

ronag commented Aug 28, 2019

Copy link
Copy Markdown
MemberAuthor

Closing for now

@ronagronag closed this Aug 28, 2019
@ronagronag mentioned this pull request Dec 15, 2019
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ronag@nodejs-github-bot@Trott@mscdex