Skip to content

gyp: cherrypick input.py from node-gyp - #29130

Closed
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:py3_input.py
Closed

gyp: cherrypick input.py from node-gyp#29130
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:py3_input.py

Conversation

@cclauss

@cclausscclauss commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

Cherrypick the Python 3 compatibility fixes from the node-gyp repo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Aug 15, 2019
@cclausscclauss added the python PRs and issues that require attention from people who are familiar with Python. label Aug 15, 2019
@cclausscclauss closed this Aug 15, 2019
@cclauss
cclauss deleted the py3_input.py branch August 15, 2019 00:50
@sam-github

sam-github commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

@cclauss did you mean to delete the branch?

@cclausscclauss mentioned this pull request Aug 15, 2019
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam-githubsam-githubAwaiting requested review from sam-github

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.pythonPRs and issues that require attention from people who are familiar with Python.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss@sam-github@nodejs-github-bot