Skip to content

doc: refine process.kill() and exit explanations - #2918

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:further-doc-process
Closed

doc: refine process.kill() and exit explanations#2918
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:further-doc-process

Conversation

@Trott

@TrottTrott commented Sep 16, 2015

Copy link
Copy Markdown
Member

R: @sam-github, @nodejs/documentation
CC: @ronkorving
Ref: #2861
Fix: #2924

@TrottTrott mentioned this pull request Sep 16, 2015
Closed
@Fishrock123Fishrock123 added the doc Issues and PRs related to the documentations. label Sep 16, 2015
@sam-github

sam-github commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

@Trott this addresses all my concerns, thank you for that, LGTM from me

@sam-github

sam-github commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

I'm not sure how fast this can be merged, the other PR was open a couple days, and only @bnoordhuis and I commented, so maybe this could merge quickly, or maybe you should wait until tomorrow in case someone does have opinions.

@Trott

Trott commented Sep 16, 2015

Copy link
Copy Markdown
MemberAuthor

@sam-github: I was just typing this:

I'll land this Wed 17-Sep around 3PM PDT/10PM UMT unless there are objections.

If you feel really good about it and want to fast-track land it sooner, I don't have a problem with that. If you leave it to me, I'm inclined to give it 24 hours.

ronkorving
ronkorving reviewed Sep 17, 2015
View reviewed changes
Comment threaddoc/api/process.markdown Outdated

@ronkorvingronkorvingSep 17, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless an event handler is listening, in the case of SIGINT and SIGTERM, right?

@TrottTrottSep 17, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes on POSIX systems, but no on Windows. That paragraph applies to Windows only.

@ronkorvingronkorvingSep 17, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks. It does sound to me then that inevitably, Node should strive to unify the behavior. If we can't get Windows to behave, perhaps we need to downgrade the POSIX behavior? (that would suck, but if that's the only way ...)

@TrottTrottSep 17, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @sam-github, should I change exit in line 248 to termination?

@sam-githubsam-githubSep 17, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, Windows doesn't support signals, so it doesn't support the distinction, but its still more consistent.

@TrottTrottSep 17, 2015

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

@ronkorvingronkorving mentioned this pull request Sep 17, 2015
Closed
@sam-github

sam-github commented Sep 17, 2015

Copy link
Copy Markdown
Contributor

LGTM

@Trott

Trott commented Sep 17, 2015

Copy link
Copy Markdown
MemberAuthor

Removed the for example part. Those details can go elsewhere, preferably somewhere that they can be explained comprehensively, such as a guide at https://github.com/nodejs/docs/tree/master/src

Trott added a commit to Trott/io.js that referenced this pull request Sep 17, 2015
@Trott
doc: refine process.kill() and exit explanations
4dcf24c
Add corrections about when exit event fires and how .kill() works on
Windows.
PR-URL: nodejs#2918
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@Trott

Trott commented Sep 17, 2015

Copy link
Copy Markdown
MemberAuthor

Landed in 4dcf24c

@TrottTrott closed this Sep 17, 2015
Trott added a commit that referenced this pull request Sep 20, 2015
@Trott@Fishrock123
doc: refine process.kill() and exit explanations
b2ddf0f
Add corrections about when exit event fires and how .kill() works on
Windows.
PR-URL: #2918
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@trevnorristrevnorris mentioned this pull request Sep 20, 2015
Closed
@rvaggrvagg mentioned this pull request Sep 22, 2015
Merged
@ronkorving

ronkorving commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

Thanks @Trott. I was afk for a few weeks, so was unable to respond for a while, but appreciate the changes 👍

@Trott
Trott deleted the further-doc-process branch January 9, 2022 22:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@sam-github@ronkorving@Fishrock123