Uh oh!
There was an error while loading. Please reload this page.
lib: rename validateSafeInteger to validateInteger - #29184
Merged
Conversation
Trott
approved these changes
Aug 17, 2019
lpinca
approved these changes
Aug 17, 2019
jasnell
approved these changes
Aug 18, 2019
ZYSzys
approved these changes
Aug 18, 2019
nodejs-github-bot
commented
Aug 18, 2019
Collaborator
nodejs-github-bot
commented
Aug 18, 2019
Collaborator
trivikr
approved these changes
Aug 18, 2019
Collaborator
CI: https://ci.nodejs.org/job/node-test-pull-request/25087/ EDIT: CI was green. |
validateInteger() was renamed to validateSafeInteger() in nodejs#26572. However, this function also works with unsafe integers. This commit restores the old name, and adds some basic tests. PR-URL: nodejs#29184 Refs: nodejs#26572 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateInteger()was renamed tovalidateSafeInteger()in #26572. However, this function also works with unsafe integers. This commit restores the old name, and adds some basic tests.Refs: #26572
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes