Uh oh!
There was an error while loading. Please reload this page.
http: simplify timeout handling - #29200
Closed
ronag wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Aug 19, 2019
Collaborator
ronagforce-pushed
the
http-client-req-timeout-refactor
branch
from
August 19, 2019 10:03
58a84b6 to
2c4cc01Comparelpinca
reviewed
Aug 19, 2019
Uh oh!
There was an error while loading. Please reload this page.
Avoids allocating and registering extra listeners for 'timeout'.
ronagforce-pushed
the
http-client-req-timeout-refactor
branch
from
August 19, 2019 19:34
2c4cc01 to
6f54858Comparelpinca
approved these changes
Aug 19, 2019
BridgeAR
approved these changes
Aug 20, 2019
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
nodejs-github-bot
commented
Aug 21, 2019
Collaborator
nodejs-github-bot
commented
Aug 22, 2019
Collaborator
nodejs-github-bot
commented
Aug 31, 2019
Collaborator
lpinca
commented
Aug 31, 2019
Member
Landed in cad3a21. |
lpinca pushed a commit
that referenced
this pull request
Aug 31, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Sep 3, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR pushed a commit
that referenced
this pull request
Sep 4, 2019
Avoids allocating and registering extra listeners for 'timeout'. PR-URL: #29200 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids allocating and registering extra listeners for 'timeout'.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes